Skip to content

Conversation

@ericcurtin
Copy link
Collaborator

@ericcurtin ericcurtin commented Jan 5, 2025

Set n_ctx equal to n_batch in Opt class. Now context size is a more reasonable 2048.

Set `n_ctx` equal to `n_batch` in `Opt` class. Now context size is
a more reasonable 2048.

Signed-off-by: Eric Curtin <[email protected]>
@ericcurtin
Copy link
Collaborator Author

This should be an easy review @slaren @ggerganov , I noticed context size was 512, when it should be 2048 by default

@ericcurtin
Copy link
Collaborator Author

Could we merge this?

@slaren slaren changed the title Context size by default should be 2048, not 512 llama-run : fix context size Jan 6, 2025
@slaren slaren merged commit dc7cef9 into ggml-org:master Jan 6, 2025
48 checks passed
@ericcurtin ericcurtin deleted the context-size-llama-run branch January 6, 2025 23:18
tinglou pushed a commit to tinglou/llama.cpp that referenced this pull request Feb 13, 2025
Set `n_ctx` equal to `n_batch` in `Opt` class. Now context size is
a more reasonable 2048.

Signed-off-by: Eric Curtin <[email protected]>
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Feb 26, 2025
Set `n_ctx` equal to `n_batch` in `Opt` class. Now context size is
a more reasonable 2048.

Signed-off-by: Eric Curtin <[email protected]>
mglambda pushed a commit to mglambda/llama.cpp that referenced this pull request Mar 8, 2025
Set `n_ctx` equal to `n_batch` in `Opt` class. Now context size is
a more reasonable 2048.

Signed-off-by: Eric Curtin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants